Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools - Use HEMTT 1.13 #226

Merged
merged 13 commits into from
Sep 13, 2024
Merged

Tools - Use HEMTT 1.13 #226

merged 13 commits into from
Sep 13, 2024

Conversation

veteran29
Copy link
Member

@veteran29 veteran29 commented Sep 3, 2024 •
edited
Loading

When merged this pull request will:

  • title
  • better linting
  • separate file for launch profiles
  • unify command casing
  • fix padded macro arguments
  • lowercase include/ folder paths so linux builds are happy

@veteran29 veteran29 added the enhancement Fixes and improvements for existing feature label Sep 4, 2024
@veteran29 veteran29 marked this pull request as ready for review September 4, 2024 14:13
@veteran29 veteran29 requested a review from a team as a code owner September 4, 2024 14:13
@veteran29 veteran29 requested review from 3Mydlo3 and removed request for a team September 4, 2024 14:13
@veteran29 veteran29 added this to the 1.17.1 milestone Sep 4, 2024
3Mydlo3
3Mydlo3 reviewed Sep 13, 2024
View reviewed changes
.hemtt/lints.toml
Comment on lines +6 to +10
"WEST",
"EAST",
"INDEPENDENT",
"RESISTANCE",
"CIVILIAN",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad those are not handled properly.

3Mydlo3
3Mydlo3 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@3Mydlo3 3Mydlo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veteran29 veteran29 merged commit 18329ee into master Sep 13, 2024
5 checks passed
@veteran29 veteran29 deleted the hemtt/1.13 branch September 13, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3Mydlo3 3Mydlo3 3Mydlo3 approved these changes

Assignees
No one assigned
Labels
enhancement Fixes and improvements for existing feature
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@veteran29 @3Mydlo3